✨ Add selectionMeta param to the onChangeRaw event call - to give additional details about the selected date
#5858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is selected - Send the `selectionMeta` only when a date is selected Closes Hacker0x01#5701
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5858 +/- ##
=======================================
Coverage 97.26% 97.26%
=======================================
Files 30 30
Lines 3441 3443 +2
Branches 1457 1458 +1
=======================================
+ Hits 3347 3349 +2
Misses 94 94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
balajis-qb
changed the title
selectionMeta param to the onChangeRaw event call when a date is selectedselectionMeta param to the onChangeRaw event call - to give additional details about the selected date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked issue: #5701
As mentioned in the linked issue, currently
onChangeRawwill just include the corresponding event as the only param. In this PR, I enhanced it a little bit by including theselectionMetawhen a day is selected. This includes the selected date object along with the formatted date string.formattedDatecontains the formatted version of the selected date.We're also emitting
onChangeRawwhen user directly change the date input value with change event, but as it's a change event and not specifically related to any day click, I'm not including the selectionMeta there.Problem
To include the additional meta of the selected date element.
Changes
selectionMetaas a second optional param - to include additional details about the selected dateonChangeRawusageScreenshots
Contribution checklist